Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For non-winrt 64-bit Windows builds #794

Open
wants to merge 28 commits into
base: master
Choose a base branch
from

Conversation

aprothman
Copy link

Use the 64-bit native compiler rather than the 32 to 64 cross compiler.
Changed the toolchain batch file to point relevant options and paths to amd64

@intoxopox
Copy link

Has anyone reviewed this for consideration?

@hughsando
Copy link
Member

The scripts should be using 'host_arch' now, eg https://github.com/HaxeFoundation/hxcpp/blob/master/toolchain/msvc-arm64-setup.bat#L16
Is this PR still needed?

@aprothman
Copy link
Author

https://github.com/HaxeFoundation/hxcpp/blob/master/toolchain/msvc64-setup.bat#L3
In the Windows x64 case, the batch file that should be run is vcvars64.bat. vcvarsx86_amd64.bat sets up the 64-bit cross compiler meant to be run from 32-bit operating systems to build 64-bit applications. It forces the build process to be run from the WOW64 subsystem. The results should be binarily compatible, but in practice they are different. Of course, we can also run into the 32-bit process memory limits for large builds while using the cross compiler.

@Simn Simn added this to the Later milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants